Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha] External Istiod - APPROVED #11

Closed
8 of 9 tasks
linsun opened this issue Oct 28, 2020 · 14 comments
Closed
8 of 9 tasks

[Alpha] External Istiod - APPROVED #11

linsun opened this issue Oct 28, 2020 · 14 comments

Comments

@linsun
Copy link
Member

linsun commented Oct 28, 2020

Alpha Feature Requirements

This page lists the requirements for promoting a feature to alpha. Please check off and document the steps as they are completed.

Feature Name:
External Istiod (formerly called central istiod)

RFC:
https://docs.google.com/document/d/1r58al52otp1uvB7YFHh8ifA_78hYeyd0hNLq4qPDSUM/edit

Design doc:
https://docs.google.com/document/d/1EymnzMqa7hdmKn8sEoaf1elajyp4gXEDSUavxzXB3jw/edit#

Relevant Documentation:
https://preliminary.istio.io/latest/docs/setup/additional-setup/external-controlplane/

Requirements:

Design

  • RFC has been approved describing the intention of the feature as well as the user stories behind the feature.

Config

  • Explicit user action is required to enable this feature (e.g. a config field, config resource, or installation action).

Link to instructions for enabling

Docs

Tests

  • Automated integration tests cover core use cases with the feature enabled.
  • When disabled, the feature does not affect system stability or performance.

API

  • Initial API review. (No API added in 1.8)

Approvals

  • The appropriate work group(s) have reviewed and approved promotion of the feature.
  • The TOC has reviewed and approved promotion of the feature as part of the
    roadmap for a release.
@linsun
Copy link
Member Author

linsun commented Nov 2, 2020

@sdake @ostromart @costinm could I get approval on this?

The docs section is lacking, but being actively worked on:

istio/istio.io#8403
Preview: https://deploy-preview-8403--preliminary-istio.netlify.app/latest/docs/setup/additional-setup/external-istiod/

Release notes/upgrade notes entry was added as experimental in 1.7 and will be added as an alpha feature as soon as the promotion to alpha is approved.

@ostromart
Copy link
Contributor

LGTM

@sdake
Copy link
Member

sdake commented Nov 3, 2020

LGTM.

@linsun
Copy link
Member Author

linsun commented Nov 6, 2020

Thanks @ostromart @sdake. Doc is also published, I've updated the checklist earlier with WG approval.

@linsun
Copy link
Member Author

linsun commented Nov 6, 2020

@istio/technical-oversight-committee seeking TOC approval, PTAL

@nrjpoddar
Copy link
Member

@linsun can you add the prelim doc links so I can take a look?

@linsun
Copy link
Member Author

linsun commented Nov 6, 2020

@nrjpoddar
Copy link
Member

This looks good, approved from my end!

@sdake
Copy link
Member

sdake commented Nov 8, 2020

@linsun would you be kind enough to submit a feature status page update as @bianpengyuan has done here for this feature promotion?

istio/istio.io#8453 (review)

Cheers,
-steve

@sdake sdake changed the title Promote External Istiod to Alpha [Alpha] External Istiod Nov 8, 2020
@linsun
Copy link
Member Author

linsun commented Nov 11, 2020

@smawson @dcberg @louiscryan @duderino another friendly ping - seeking TOC approval, PTAL

@smawson
Copy link
Contributor

smawson commented Nov 11, 2020

Approved from me! A couple minor nits:

  • RFC needs to be marked as approved and missing a few official signoffs.
  • istio.io docs should indicate this is in alpha

Otherwise looks good, this is a great feature.

@dcberg
Copy link

dcberg commented Nov 12, 2020

+1

1 similar comment
@louiscryan
Copy link

+1

@linsun
Copy link
Member Author

linsun commented Nov 13, 2020

Thank you all, much appreciated, I'll mark this as approved!!

@linsun linsun closed this as completed Nov 13, 2020
@linsun linsun changed the title [Alpha] External Istiod [Alpha] External Istiod - APPROVED Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants