Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] bazel: replace tclap mirror. (#9072) #124

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

yxue
Copy link
Member

@yxue yxue commented Nov 20, 2019

Description:

Change (non-existent) https://github.com/eile/tclap/ to https://github.com/mirror/tclap/. I didn't validate the new mirror in any way, but the downloded release file sha256sum stays the same. In the future the releases should probably be downloaded from the real upstream. However the release 1.2.1 tarball from https://sourceforge.net/projects/tclap/files/ did not have the same sha256sum as the release file which Envoy uses.

Risk Level: Medium
Testing: N/A
Docs Changes: N/A
Release Notes:
Fixes envoyproxy#9071

Signed-off-by: Ismo Puustinen ismo.puustinen@intel.com
Signed-off-by: Yan Xue yxyan@google.com

Description:

Change (non-existent) https://github.com/eile/tclap/ to https://github.com/mirror/tclap/. I didn't validate the new mirror in any way, but the downloded release file sha256sum stays the same. In the future the releases should probably be downloaded from the real upstream. However the release 1.2.1 tarball from https://sourceforge.net/projects/tclap/files/ did not have the same sha256sum as the release file which Envoy uses.

Risk Level: Medium
Testing: N/A
Docs Changes: N/A
Release Notes:
Fixes envoyproxy#9071 

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
Signed-off-by: Yan Xue <yxyan@google.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@yxue yxue changed the title bazel: replace tclap mirror. (#9072) [release-1.2] bazel: replace tclap mirror. (#9072) Nov 20, 2019
@fpesce fpesce added cla: yes and removed cla: no labels Nov 20, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@fpesce
Copy link

fpesce commented Nov 20, 2019

CLA: from a googler.

@fpesce fpesce merged commit 8dd3443 into istio:release-1.2 Nov 20, 2019
howardjohn pushed a commit that referenced this pull request Mar 3, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
brian-avery pushed a commit that referenced this pull request Jun 30, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Jianfei Hu <jianfeih@google.com>
Co-authored-by: Lizan Zhou <lizan@tetrate.io>
Miss-you pushed a commit to Miss-you/envoy that referenced this pull request Nov 17, 2020
zh-translation: docs/root/intro/version_history.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants