This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
fix kind issue in CI. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
requested review from
costinm,
howardjohn,
linsun and
sdake
as code owners
costinm
approved these changes
May 9, 2019
|
For the record - I'm not sure 0.2.1 is best option, it's from Mar27 - and may not work with the image we built. Maybe we can checkout on SHA, from 2-3 days ago ? We'll also need a similar fix in the Docker image, but less urgent. And thanks for the quick fix ! |
|
Yes, it's really annoying that |
BenTheElder
reviewed
May 9, 2019
| @@ -278,7 +278,7 @@ git.dep: ${GOPATH}/src/istio.io/istio ${GOPATH}/src/istio.io/tools | |||
| ${GOPATH}/bin/kind: | |||
| echo ${GOPATH} | |||
| mkdir -p ${TMPDIR} | |||
| go get -u sigs.k8s.io/kind | |||
| git clone https://github.com/kubernetes-sigs/kind ${GOPATH}/src/sigs.k8s.io/kind && cd ${GOPATH}/src/sigs.k8s.io/kind && git checkout v0.2.1 && go install . | |||
There was a problem hiding this comment.
another option if docker is available and HEAD is still desired is:
Suggested change
| git clone https://github.com/kubernetes-sigs/kind ${GOPATH}/src/sigs.k8s.io/kind && cd ${GOPATH}/src/sigs.k8s.io/kind && git checkout v0.2.1 && go install . | |
| git clone https://github.com/kubernetes-sigs/kind && cd kind && make install |
I do think we should instead get another kind release out and would request sticking to released versions for CI given the alpha state.
There was a problem hiding this comment.
Thanks, let me have a try.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kindin master is broken, see: kubernetes-sigs/kind#509, use released version as a workaround.