This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
[WIP]fix kind build issue. #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
requested review from
costinm,
howardjohn,
linsun and
sdake
as code owners
|
/hold |
|
We need to address: https://github.com/istio/installer/issues/141 before merging this. |
|
I think we got some fixes merge for this, or this still relevant? |
costinm
approved these changes
May 9, 2019
|
Once again - the real fix is to add the same lines to istio/istio/.circleci/Dockerfile - so we don't have to do that on each test. |
|
Fixed in #145, closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #139, as it's just a short-term fix and
kindreleased versionv0.2.1might not be outdated. We would prefer to the edge kind.