Test framework .Call fails due to port mismatch

[howardjohn]

func ExternalRequest(expectedKnownPort []string, t *testing.T) {
	framework.
		NewTest(t).
		//RequiresEnvironment(environment.Kube).
		Run(func(ctx framework.TestContext) {
			g := galley.NewOrFail(t, ctx, galley.Config{})
			pilotInstance := pilot.NewOrFail(t, ctx, pilot.Config{Galley: g})

			instance := apps.NewOrFail(ctx, t, apps.Config{
				Pilot: pilotInstance,
				AppParams: []apps.AppParam{
					{"client"},
					{"dest"},
				},
			})


			client := instance.GetAppOrFail("client", t)
			dest := instance.GetAppOrFail("dest", t)

			for _, ep := range dest.EndpointsForProtocol(model.ProtocolHTTP) {
				resp, err := client.Call(ep, apps.AppCallOptions{})
				codes := make([]string, 0, len(resp))
				for _, r := range resp {
					codes = append(codes, r.Code)
				}
				if !reflect.DeepEqual(codes, expectedKnownPort) {
					log.Errorf("got codes %v expected %v for known port\n", codes, expectedKnownPort)
				}
				if err != nil {
					t.Error(err)
				}
			}
		})

This fails with:

    helper.go:63: unexpected port: 8080 (expected 80)
    helper.go:63: unexpected port: 80 (expected 8080)

I think this is because we have:

  - port: 80
    targetPort: 8080
    name: http
  - port: 8080
    targetPort: 80
    name: http-two

in the Service.

https://github.com/istio/istio/blob/master/pkg/test/framework/components/apps/kube.go#L619-L621

[howardjohn]

I think we can just remove the check, unless there is some context I am missing why we have it

[nmittler]

@howardjohn I think this should be resolved in #13175. The echo component has been re-written to support both native and kube. It also has the separation of servicePort and instancePort (i.e. TargetPort). Would you mind trying it out and confirming?

[ozevren]

@howardjohn did you get a chance to look at @nmittler's recommendation?

[nmittler]

I think this should fix it: #13443

[howardjohn]

Fixed

[nmittler]

@howardjohn what PR fixed this?