Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Framework] Fix apps forwarder port #13443

Closed
wants to merge 1 commit into from

Conversation

nmittler
Copy link
Contributor

Was using the service port, but should have been using the target port.

Fixes #13091

Was using the service port, but should have been using the target port.

Fixes istio#13091
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmittler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@nmittler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh 48f1d10 link /test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented May 3, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label May 3, 2019
@ozevren
Copy link
Contributor

ozevren commented May 3, 2019

I don't remember seeing this PR, I missed this. Is it still relevant?

@stale stale bot removed the stale label May 3, 2019
@nmittler
Copy link
Contributor Author

nmittler commented May 3, 2019

@ozevren I'm about to replace apps with echo now, so I'll just close this out at that point.

@nmittler
Copy link
Contributor Author

No longer applies, since apps has been replaced by Echo. Closing.

@nmittler nmittler closed this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test framework .Call fails due to port mismatch
4 participants