Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istio/tools - replace config changer with CronJob #17353

Closed
howardjohn opened this issue Sep 24, 2019 · 0 comments · Fixed by istio/tools#380
Closed

istio/tools - replace config changer with CronJob #17353

howardjohn opened this issue Sep 24, 2019 · 0 comments · Fixed by istio/tools#380

Comments

@howardjohn
Copy link
Member

Our users are running CronJobs (#11659) but we aren't, so we don't find any bugs until its too late. We should replace our configchanger pods in https://github.com/istio/tools/blob/master/perf/load/templates/config-changer.yaml with a cronjob

howardjohn added a commit to howardjohn/tools that referenced this issue Sep 27, 2019
This is mostly to get coverage of using CronJobs with Istio, something
we don't have a lot of testing of but that our customers often use.

Fixes istio/istio#17353
istio-testing pushed a commit to istio/tools that referenced this issue Sep 27, 2019
* Use CronJob for deployment scaler

This is mostly to get coverage of using CronJobs with Istio, something
we don't have a lot of testing of but that our customers often use.

Fixes istio/istio#17353

* Fixes
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this issue Jun 30, 2022
* Use CronJob for deployment scaler

This is mostly to get coverage of using CronJobs with Istio, something
we don't have a lot of testing of but that our customers often use.

Fixes istio/istio#17353

* Fixes
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this issue Jul 6, 2022
* Use CronJob for deployment scaler

This is mostly to get coverage of using CronJobs with Istio, something
we don't have a lot of testing of but that our customers often use.

Fixes istio/istio#17353

* Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant