-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
istioctl manifest has many unnecessary destination rule just for the tls.DISABLE #18654
Labels
Comments
istio-1.4-alpha.4c58b3d2f32c715f2188f227774256e2f81d865b build. |
I confirmed the old helm yaml does not have this issue
|
@incfly noticed this as well, I am going to send a change to delete them |
howardjohn
added a commit
to howardjohn/istio-installer
that referenced
this issue
Nov 5, 2019
See istio/istio#18654 This is especially bad because the config will be reconciled, so even if manually fixed will still break
istio-testing
pushed a commit
to istio/installer
that referenced
this issue
Nov 6, 2019
* Kill unneeded/broken DestinationRules See istio/istio#18654 This is especially bad because the config will be reconciled, so even if manually fixed will still break * api-server only when mtls enabled * gen
istio-testing
pushed a commit
to istio-testing/installer
that referenced
this issue
Nov 6, 2019
See istio/istio#18654 This is especially bad because the config will be reconciled, so even if manually fixed will still break
istio-testing
added a commit
to istio/installer
that referenced
this issue
Nov 6, 2019
* Kill unneeded/broken DestinationRules See istio/istio#18654 This is especially bad because the config will be reconciled, so even if manually fixed will still break * api-server only when mtls enabled * gen
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug description
Many of them are just for setting the TLS, which I don't think is needed.
I didn't see that in previous demo profile and helm install, I haven't verified in 1.4.
[ X] Installation
Expected behavior
Steps to reproduce the bug
Version (include the output of
istioctl version --remote
andkubectl version
)How was Istio installed?
istioctl manifest apply --set profile=demo
The text was updated successfully, but these errors were encountered: