Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkloadEntry auto register race #28743

Closed
hzxuzhonghu opened this issue Nov 10, 2020 · 2 comments · Fixed by #28785
Closed

WorkloadEntry auto register race #28743

hzxuzhonghu opened this issue Nov 10, 2020 · 2 comments · Fixed by #28785
Labels
area/networking

Comments

@hzxuzhonghu
Copy link
Member

We register the workload entry when it first connects to istiod, however if the workloadentry is not propagated back to the serviceentry store, then we will get no serviceinstances for this proxy. Then istiod can not geneerate right xds configs for this proxy.

And the workloadentry handler mainly triggers eds push, which will not update proxy at all.
@hzxuzhonghu hzxuzhonghu mentioned this issue Nov 11, 2020
Merged
@stevenctl
Copy link
Contributor

Seems like this would affect more than just auto-registration. We don't really advise users to create a WorkloadEntry before they connect their VM to pilot.

@hzxuzhonghu
Copy link
Member Author

Correct, a legacy issue

@hzxuzhonghu hzxuzhonghu mentioned this issue Nov 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workloadentry add should trigger push to the proxy hzxuzhonghu/istio
2 participants
@hzxuzhonghu @stevenctl