Adopt go 1.18 net/netip package

[howardjohn]

New package for IPs, CIDRs, etc. We should consider if it makes sense to replace any of our current usage, since the package is pretty nice. Not sure if it can replace our CIDR usages or not.

[howardjohn]

not stale

…

On Tue, Sep 6, 2022 at 10:03 PM Istio Policy Bot ***@***.***> wrote: 🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2022-06-08. It will be closed on 2022-09-21 unless an Istio team member takes action. Please see this wiki page <https://github.com/istio/istio/wiki/Issue-and-Pull-Request-Lifecycle-Manager> for more information. Thank you for your contributions. *Created by the issue and PR lifecycle manager*. — Reply to this email directly, view it on GitHub <#39348 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYGXLJPDYYK75YDS5B27TV5AOZ3ANCNFSM5YHAZ35A> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[saltbo]

I want to try to submit a PR, hope to get some guidance.

[zhlsunshine]

Hi @howardjohn, @ramaraochavali & @hzxuzhonghu, there is a blog post explains the advantages of netaddr.IP over net.IP
So I suggest that the phase 1 should be that:

1. use struct Addr defined in netip package: we can start from some places where use net.ip or net.ipaddr
2. replace net.ParseIP into netip.ParseAddr

Any idea?

[saltbo]

I found there are many net.ParseIP, and I want to replace the net.ParseCIDR first.

[saltbo]

some third-party pkgs no update to netip, eg: yl2chen/cidranger#46 and https://github.com/vishvananda/netlink

[saltbo]

pkg/dns/client depend on https://github.com/miekg/dns, but the mod seem no plan to upgrade to netip

miekg/dns#1388

[zhlsunshine]

More dependencies on

1. https://github.com/yl2chen/cidranger which still use go 1.13
2. https://github.com/vishvananda/netlink which still use go 1.12

[charles-chenzz]

hi, do we finish the migrate yet? if not can I join? @zhlsunshine

[zhlsunshine]

Hi @charles-chenzz, I think the answer is no, sure, you can join to help on it. Thanks!

[tjons]

@howardjohn is there any work left to do here that I can help out with or has the migration been finished?

[linsun]

cc @zhlsunshine since you worked on this quite a bit ^^ @tjons is interested in helping out

[zhlsunshine]

@linsun sure, it should be helpful if @tjons can join in.

[tjons]

@zhlsunshine awesome, I'll work on it some this weekend. Anywhere in particular you'd suggest I start?

[zhlsunshine]

@zhlsunshine awesome, I'll work on it some this weekend. Anywhere in particular you'd suggest I start?

@tjons I suggest that you can start from the istio-cni, then listener/endpoint builder related etc. Most of istio-cni has been changed, but I think there might be some missing for it.