Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace net.ParseCIDR with pkg/config in ValidateIPv4LoopbackCidr #48736

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

LZiHaN
Copy link
Member

@LZiHaN LZiHaN commented Jan 10, 2024

Please provide a description of this PR:
replace net.ParseCIDR with pkg/config in ValidateIPv4LoopbackCidr
refer to #39348

@LZiHaN LZiHaN requested a review from a team as a code owner January 10, 2024 07:01
@istio-policy-bot istio-policy-bot added area/networking release-notes-none Indicates a PR that does not require release notes. labels Jan 10, 2024
@istio-policy-bot
Copy link

😊 Welcome @LZiHaN! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

Copy link

linux-foundation-easycla bot commented Jan 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LZiHaN / name: Zihan Li (c361dfd)

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Jan 10, 2024
@istio-testing
Copy link
Collaborator

Hi @LZiHaN. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 10, 2024
@hanxiaop
Copy link
Member

/test integ-operator-controller

@istio-testing istio-testing merged commit 87d0d97 into istio:master Jan 11, 2024
28 checks passed
@LZiHaN LZiHaN deleted the refa-config-validation branch January 11, 2024 02:48
liwenhao0810 pushed a commit to liwenhao0810/istio that referenced this pull request Feb 1, 2024
thedebugger pushed a commit to thedebugger/istio that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants