Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug interface crash #40384

Closed
howardjohn opened this issue Aug 10, 2022 · 2 comments · Fixed by #40393
Closed

Debug interface crash #40384

howardjohn opened this issue Aug 10, 2022 · 2 comments · Fixed by #40393
Assignees
@howardjohn

Comments

@howardjohn
Copy link
Member

https://storage.googleapis.com/istio-prow/logs/integ-k8s-116_istio_postsubmit/1555579423959289856/artifacts/telemetry-stats-prometheus-nullvm-/TestAccessLogsDefaultProvider/enabled/_test_context/istio-state4286690722/primary-0/istiod-96b7985cb-nf4gr_discovery.log

Likely from #40151
@howardjohn
Copy link
Member Author

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/40386/integ-pilot_istio/1557408870136025088/artifacts/pilot-5ba96fc6fc3a4019a130ed059/TestGateway/_test_context/istio-system-state1605635417/primary-0/istiod-589f9ffd8f-6nvb7_discovery.previous.log

howardjohn added a commit to howardjohn/istio that referenced this issue Aug 10, 2022
@howardjohn
debug interface: fix crash regression
5c74424 
Fixes istio#40384

The issue is before we had some somewhat odd ordering to apply the
DebugMux to the debugGen. This changes it to be more explicit - and more
importantly correct as we correctly pass it a non-nil mux
@howardjohn howardjohn assigned howardjohn and unassigned stevenctl Aug 10, 2022
@howardjohn
Copy link
Member Author

@stevenctl I picked it up since you are OOO, hopefully you didn't start on it already

@howardjohn howardjohn mentioned this issue Aug 10, 2022
Merged
istio-testing pushed a commit that referenced this issue Aug 11, 2022
@howardjohn
debug interface: fix crash regression (#40393)
1d3fdfd 
* debug interface: fix crash regression

Fixes #40384

The issue is before we had some somewhat odd ordering to apply the
DebugMux to the debugGen. This changes it to be more explicit - and more
importantly correct as we correctly pass it a non-nil mux

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howardjohn howardjohn

Labels
None yet
Projects
Prioritization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debug interface: fix crash regression howardjohn/istio
2 participants
@howardjohn @stevenctl