Consider ServiceEntry weight in EDS #14616
Conversation
ServiceEntry can specify a weight. When using DNS resolution (CDS) this will be considered, but it was ignored for EDS.
| addr := util.GetNetworkEndpointAddress(e) | ||
|
|
||
| epWeight := e.LbWeight |
There was a problem hiding this comment.
we may want to clean up this code duplication in the future, it makes it easy to make a mistake when making a change like ths
pilot/pkg/proxy/envoy/v2/eds.go
Outdated
| locLbEps.LoadBalancingWeight = &types.UInt32Value{ | ||
| Value: uint32(len(locLbEps.LbEndpoints)), | ||
| Value: uint32(weight), |
There was a problem hiding this comment.
unnecessary conversion (from unconvert)
|
@howardjohn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @hzxuzhonghu |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ServiceEntry can specify a weight. When using DNS resolution (CDS) this
will be considered, but it was ignored for EDS.
Fixes #14466