Remove lowered resource limits from demo (bp #14674) #14704

mergify · 2019-06-11T18:11:53Z

This is an automated backport of pull request #14674 done by Mergify.io

This is NOT removing the limits completely, the install will still use the default limits. This makes it so users that use the demo are less likely to get horrible performance due to throttling or OOM kills decide not to use Istio. (cherry picked from commit 69f92ae)

googlebot · 2019-06-11T18:11:56Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

istio-testing · 2019-06-11T18:12:06Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mergify[bot]
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake

If they are not already assigned, you can assign the PR to them by writing /assign @sdake in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

istio-testing · 2019-06-11T18:12:08Z

Hi @mergify[bot]. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

howardjohn · 2019-06-11T18:33:28Z

/ok-to-test

googlebot · 2019-06-11T18:34:05Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

howardjohn · 2019-06-11T18:34:16Z

Set CLA to yes as I wrote this change and I have signed the CLA

codecov · 2019-06-11T18:49:49Z

Codecov Report

Merging #14704 into release-1.2 will increase coverage by 1%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.2   #14704   +/-   ##
============================================
+ Coverage           77%      77%   +1%     
============================================
  Files              495      495           
  Lines            48245    48292   +47     
============================================
+ Hits             36835    36891   +56     
+ Misses            9525     9515   -10     
- Partials          1885     1886    +1

Impacted Files	Coverage Δ
pilot/pkg/model/destination_rule.go	`69% <0%> (-5%)`	⬇️
pkg/keepalive/options.go	`100% <0%> (ø)`	⬆️
pilot/pkg/proxy/envoy/v2/ads.go	`80% <0%> (+2%)`	⬆️
pilot/pkg/model/authorization.go	`77% <0%> (+4%)`	⬆️
pilot/pkg/serviceregistry/consul/monitor.go	`90% <0%> (+5%)`	⬆️
pilot/pkg/proxy/envoy/v2/cds.go	`79% <0%> (+7%)`	⬆️
security/pkg/k8s/configmap/configmap.go	`83% <0%> (+13%)`	⬆️

fpesce · 2019-06-11T21:02:06Z

/test integ-mixer-k8s-presubmit-tests-release-1.2
/test integ-pilot-k8s-presubmit-tests-release-1.2
/test integ-security-k8s-presubmit-tests-release-1.2

howardjohn · 2019-06-11T23:05:56Z