Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] Remove lowered resource limits from demo (bp #14674) #14776

Merged
merged 1 commit into from Jun 13, 2019

Conversation

howardjohn
Copy link
Member

This is NOT removing the limits completely, the install will still use
the default limits.

This makes it so users that use the demo are less likely to get horrible
performance due to throttling or OOM kills decide not to use Istio.

(cherry picked from commit 69f92ae)

#14704
#14666

This is NOT removing the limits completely, the install will still use
the default limits.

This makes it so users that use the demo are less likely to get horrible
performance due to throttling or OOM kills decide not to use Istio.

(cherry picked from commit 69f92ae)
Copy link
Member

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants