[release-1.3] Fix rewriting of istio-cni Helm charts in release scripts #16524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the hub and tag in values_gke.yaml in addition to values.yaml. Remove the "git clone ...cni.git" and values.yaml rewriting from create_charts(), which are redundant with the cloning in create_release_archives.sh and the rewriting in update_helm().
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
brian-avery
approved these changes
Aug 23, 2019
|
@istio-testing: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test istio-unit-tests-release-1.3 |
|
/test istio-racetest-release-1.3 |
|
/test istio-codecov-release-1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #16492