-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rewriting of istio-cni Helm charts in release scripts #16492
Conversation
We'll check that the release script still works with the daily release build tonight before backporting to |
Rewrite the hub and tag in values_gke.yaml in addition to values.yaml. Remove the "git clone ...cni.git" and values.yaml rewriting from create_charts(), which are redundant with the cloning in create_release_archives.sh and the rewriting in update_helm().
|
/test e2e-simpleTestsMinProfile-master |
/cherrypick release-1.3 |
@rlenglet: new pull request created: #16524 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rewrite the hub and tag in values_gke.yaml in addition to
values.yaml.
Remove the "git clone ...cni.git" and values.yaml rewriting from
create_charts(), which are redundant with the cloning in
create_release_archives.sh and the rewriting in update_helm().
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure