Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewriting of istio-cni Helm charts in release scripts #16492

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Fix rewriting of istio-cni Helm charts in release scripts #16492

merged 1 commit into from
Aug 23, 2019

Conversation

rlenglet
Copy link
Contributor

Rewrite the hub and tag in values_gke.yaml in addition to
values.yaml.

Remove the "git clone ...cni.git" and values.yaml rewriting from
create_charts(), which are redundant with the cloning in
create_release_archives.sh and the rewriting in update_helm().

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[x] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@rlenglet rlenglet added this to the 1.3 milestone Aug 22, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 22, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2019
@rlenglet
Copy link
Contributor Author

We'll check that the release script still works with the daily release build tonight before backporting to release-1.3.

@rlenglet rlenglet added the do-not-merge/hold Block automatic merging of a PR. label Aug 22, 2019
Rewrite the hub and tag in values_gke.yaml in addition to
values.yaml.

Remove the "git clone ...cni.git" and values.yaml rewriting from
create_charts(), which are redundant with the cloning in
create_release_archives.sh and the rewriting in update_helm().
@rlenglet rlenglet removed the do-not-merge/hold Block automatic merging of a PR. label Aug 22, 2019
@rlenglet
Copy link
Contributor Author

e2e-simpleTestsMinProfile-master failed because KinD couldn't start:

time="23:50:00" level=debug msg="Using kubeadm config:\napiServer:\n  certSANs:\n  - localhost\n  - 127.0.0.1\n  extraArgs:\n    service-account-issuer: kubernetes.default.svc\n    service-account-signing-key-file: /etc/kubernetes/pki/sa.key\napiVersion: kubeadm.k8s.io/v1beta2\nclusterName: istio-testing\ncontrolPlaneEndpoint: 172.17.0.2:6443\ncontrollerManager:\n  extraArgs:\n    enable-hostpath-provisioner: \"true\"\nkind: ClusterConfiguration\nkubernetesVersion: v1.15.0\nname: config\nnetworking:\n  podSubnet: 10.244.0.0/16\n  serviceSubnet: 10.96.0.0/12\nscheduler:\n  extraArgs: null\n---\napiVersion: kubeadm.k8s.io/v1beta2\nbootstrapTokens:\n- token: abcdef.0123456789abcdef\nkind: InitConfiguration\nlocalAPIEndpoint:\n  advertiseAddress: 172.17.0.2\n  bindPort: 6443\nnodeRegistration:\n  criSocket: /run/containerd/containerd.sock\n  kubeletExtraArgs:\n    fail-swap-on: \"false\"\n    node-ip: 172.17.0.2\n---\napiVersion: kubeadm.k8s.io/v1beta2\ncontrolPlane:\n  localAPIEndpoint:\n    advertiseAddress: 172.17.0.2\n    bindPort: 6443\ndiscovery:\n  bootstrapToken:\n    apiServerEndpoint: 172.17.0.2:6443\n    token: abcdef.0123456789abcdef\n    unsafeSkipCAVerification: true\nkind: JoinConfiguration\nnodeRegistration:\n  criSocket: /run/containerd/containerd.sock\n  kubeletExtraArgs:\n    fail-swap-on: \"false\"\n    node-ip: 172.17.0.2\n---\napiVersion: kubelet.config.k8s.io/v1beta1\nevictionHard:\n  imagefs.available: 0%\n  nodefs.available: 0%\n  nodefs.inodesFree: 0%\nimageGCHighThresholdPercent: 100\nkind: KubeletConfiguration\n---\napiVersion: kubeproxy.config.k8s.io/v1alpha1\nkind: KubeProxyConfiguration\n"
time="23:50:00" level=debug msg="Running: /usr/bin/docker [docker exec --privileged istio-testing-control-plane mkdir -p /kind]"
time="23:50:00" level=error msg="failed with:"
time="23:50:00" level=error msg="OCI runtime exec failed: exec failed: container_linux.go:348: starting container process caused \"process_linux.go:90: adding pid 961 to cgroups caused \\\"failed to write 961 to cgroup.procs: write /sys/fs/cgroup/cpu,cpuacct/docker/89232e6ecb5ad5e7470f70cfaa737a3c333e3b55ae43e7310b4c6c69c5ab7065/cgroup.procs: invalid argument\\\"\": unknown"
 ✗ Creating kubeadm config 📜
Error: failed to create cluster: failed to copy kubeadm config to node: failed to create directory /kind/kubeadm.conf: exit status 126
+ echo 'Could not setup KinD environment. Something wrong with KinD setup. Exporting logs.'

@rlenglet
Copy link
Contributor Author

/test e2e-simpleTestsMinProfile-master

@istio-testing istio-testing merged commit 0f098c3 into istio:master Aug 23, 2019
@rlenglet rlenglet deleted the fix-cni-release branch August 23, 2019 22:49
@rlenglet
Copy link
Contributor Author

/cherrypick release-1.3

@istio-testing
Copy link
Collaborator

@rlenglet: new pull request created: #16524

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test and release cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants