-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the helm templates to support Control Plane SDS (#16466) #16533
Conversation
* support control plane SDS * test control plane SDS * revise * revise * revise * set env * revise * revise * revise * revise * revise * revise * template change for SDS control plane * revise * update * fix unit tests * fix tests * enable control plane SDS
manually create a PR that cherry-picks #16466 |
/cc @myidpt |
@@ -236,6 +236,8 @@ spec: | |||
valueFrom: | |||
fieldRef: | |||
fieldPath: metadata.namespace | |||
- name: SDS_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JimmyCYJ Please update this PR's description to link to the equivalent PR that updates the new installer. If you won't update the new installer, please explain why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@myidpt Could you provide any context about equivalent changes to new installer?
/retest |
The unit tests fail because #16462 is cherry-picked into 1.3 branch, which changes auth_golden.json and running_golden.json. I have to update authsds_golden.json and runningsds_golden.json accordingly. |
@JimmyCYJ: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure