Fixing the helm templates to support Control Plane SDS #16466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyCYJ
requested review from
andraxylia,
costinm,
diemtvu,
GregHanson,
howardjohn,
hzxuzhonghu,
linsun,
mandarjog,
morvencao,
nmittler,
ostromart,
rshriram,
sdake,
vadimeisenbergibm and
ZackButcher
as code owners
|
@howardjohn could you please take a look? The Pilot agent change is already merged and cherry-picked into 1.3 |
howardjohn
approved these changes
Aug 23, 2019
|
@JimmyCYJ approved but I am not an owner |
myidpt
approved these changes
Aug 23, 2019
|
@howardjohn Thanks for the review. |
|
@howardjohn Thanks a lot! |
|
@sdake could you please take a look? |
sdake
reviewed
Aug 23, 2019
sdake
approved these changes
Aug 23, 2019
|
/retest |
1 similar comment
|
/retest |
|
@JimmyCYJ: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
morvencao
reviewed
Aug 24, 2019
| @@ -236,6 +236,8 @@ spec: | |||
| valueFrom: | |||
| fieldRef: | |||
| fieldPath: metadata.namespace | |||
| - name: SDS_ENABLED | |||
| value: "{{ $.Values.global.sds.enabled }}" | |||
There was a problem hiding this comment.
nit: maybe better to replace "{{ $.Values.global.sds.enabled }}" with {{ $.Values.global.sds.enabled | quote }}
|
In response to a cherrypick label: #16466 failed to apply on top of branch "release-1.3": |
|
/cherrypick release-1.3 |
|
@JimmyCYJ: #16466 failed to apply on top of branch "release-1.3": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
JimmyCYJ
added a commit
to JimmyCYJ/istio
that referenced
this pull request
Aug 24, 2019
* support control plane SDS * test control plane SDS * revise * revise * revise * set env * revise * revise * revise * revise * revise * revise * template change for SDS control plane * revise * update * fix unit tests * fix tests * enable control plane SDS
istio-testing
pushed a commit
that referenced
this pull request
Aug 25, 2019
* Fixing the helm templates to support Control Plane SDS (#16466) * support control plane SDS * test control plane SDS * revise * revise * revise * set env * revise * revise * revise * revise * revise * revise * template change for SDS control plane * revise * update * fix unit tests * fix tests * enable control plane SDS * fix test golden files * fix tests
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* istio#16223 * istio#16272 * istio#16187 * istio#16466 * istio#16634 * istio#16594 * istio#16666 * istio#16483 * istio#16820 * istio#16842 * istio#16852 * istio#16835 * istio#16863 * istio#16892 * istio#16991 * istio#16957 * istio#17013 * istio#17134 * istio#17155 * istio#17235 * istio#17342 * istio#17477 * istio#17615 * istio#17334 * istio#17708 * istio#17737 * Fix injection template * Fix quoting * Fix test values * Add accidentally deleted affinity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the helm templates to support control plane security with SDS. Before this change, the control plane security cannot be enabled with SDS enabled.
[ ] Configuration Infrastructure
[ ] Docs
[ x ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ x ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
#11434