-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(injection template): correct owner string format #18485
Conversation
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the right format here? I have seen other similar PRs before, not sure what format this actually expects?
@howardjohn i too get a bit lost. i'm going off of the URLS in https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#-strong-read-operations-deployment-v1-apps-strong- |
@howardjohn did this get CP'd correctly? i don't see the bot info here. |
/cherry-pick release-1.4 |
@bianpengyuan: #18485 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
That label does not quite seem to work now. The command could make it do the work. |
But seems like we need a manual cherry-pick... |
* fix(injection template): correct owner string format Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * refresh golden files
Missing the 's' in 'apis'. This update matches the changes to the injection-template.yaml in #18485.
This PR is meant to cover fixes such as: - istio/istio#18485 - istio/istio#19513
Missing the 's' in 'apis'. This update matches the changes to the injection-template.yaml in #18485.
Missing the 's' in 'apis'. This update matches the changes to the injection-template.yaml in istio#18485.
Missing the 's' in 'apis'. This update matches the changes to the injection-template.yaml in #18485.
* fix(templates): Correct OWNER urls. This PR is meant to cover fixes such as: - istio/istio#18485 - istio/istio#19513 * Update injection-template.yaml * Update deployment.yaml
This PR is meant to cover fixes such as: - istio/istio#18485 - istio/istio#19513
* fix(templates): Correct OWNER urls. This PR is meant to cover fixes such as: - istio/istio#18485 - istio/istio#19513 * Update injection-template.yaml * Update deployment.yaml
Missing the 's' in 'apis'. This update matches the changes to the injection-template.yaml in istio#18485.
The ISTIO_META_OWNER field is improperly specified in the injection template. This PR fixes it.