ingress: use SDS, remove preconfigured gateway #22227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
istio-testing
added
the
size/L
This makes some improvements to our Ingress support. First, we remove the Gateway installed during install. Then we can fix the autogenerated internal Gateway to "properly" select the correct gateway deployment. This should be configurable, I will add this once we add support for IngressClass. Next, support multiple `tls` blocks, and use SDS to pass these. This aligns great with the Ingress model, where we are pointing to Secrets already. I also had to fix the controller to properly trigger events on Gateway changes. I also extended the tests to include HTTPS calls.
howardjohn
force-pushed
the
pilot/ingress-fix
branch
from
0b1a1d1
to
b501035
Compare
esnible
approved these changes
Mar 17, 2020
rshriram
approved these changes
Mar 17, 2020
liamawhite
approved these changes
Mar 17, 2020
elfinhe
approved these changes
Mar 17, 2020
elfinhe
approved these changes
Mar 17, 2020
|
@howardjohn do you know under which Istio version will this be released? |
|
1.6
…On Wed, May 13, 2020, 6:03 AM Guy Rombaut ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn> do you know under which Istio
version will this be released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22227 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXJVZMY7WOSWR7ADTRLRRKLBLANCNFSM4LMWDWMA>
.
|
|
Thanks @howardjohn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some improvements to our Ingress support. First, we remove
the Gateway installed during install. Then we can fix the autogenerated
internal Gateway to "properly" select the correct gateway deployment.
This should be configurable, I will add this once we add support for
IngressClass.
Next, support multiple
tlsblocks, and use SDS to pass these. Thisaligns great with the Ingress model, where we are pointing to Secrets
already.
I also had to fix the controller to properly trigger events on Gateway
changes.
I also extended the tests to include HTTPS calls.
I recommend we merge #22134 in before this so we can have better testing