Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the galley deployment #22632

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Mar 31, 2020

In the networking WG we agreed to remove the galley deployment for 1.6. The validation and status controllers have migrated to Istiod. The remaining feature gap is an MCP source, which we have decided to drop support for. (NOTE: istiod still can act as an MCP sync).

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 31, 2020
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 31, 2020
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2020
@@ -1,133 +0,0 @@
// Copyright 2018 Istio Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ported over to istiod since we support status updates there now. @therealmitchconnors, this should mostly be copy/paste except for enabling the analysis feature, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mitch already added this to istiod with tests in #22364 - or at least I think this is the same feature?

@howardjohn howardjohn changed the title DNM: disable galley Remove the galley deployment Apr 2, 2020
@howardjohn howardjohn marked this pull request as ready for review April 2, 2020 16:36
@howardjohn howardjohn requested review from a team as code owners April 2, 2020 16:36
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 2, 2020
@ericvn
Copy link
Contributor

ericvn commented Apr 3, 2020

/retest

Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants