make xds send timeout configurable #27687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-policy-bot
added
area/networking
release-notes-none
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
howardjohn
approved these changes
Oct 2, 2020
|
/test unit-tests_istio |
|
What is your env that this occurs, purely increase timeout may mask some real error. |
|
It happens on k8s 1.16. This only happens on dev clusters not on test/stage/prod. I suspect it is because of huge configurations sent because of number of services. I would like to see if this helps. Also I am thinking of adding a metric to record the send times - so that we can see how it is doing with various cluster sizes |
|
make sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing "2020-09-25T18:36:23.207985Z info ads Timeout writing sidecar~10.100.181.200" in some envs occasionally.
Making this configurable to test if it helps
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X ] Does not have any changes that may affect Istio users.