-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise istioctl global flags displaying in options, and organize flag sets #40982
Conversation
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release note looks good
@hanxiaop: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Why is this better? it just seems needlessly verbose? |
@howardjohn Some of the global flags are displayed in the help func but some of them are in the |
@hanxiaop: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-09-20. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions. Created by the issue and PR lifecycle manager. |
Please provide a description of this PR:
Originally #37938 was resolved in #38236. However it broke all
--help
commands, see #38236 (review). This PR addresses the problem, and organizes all the flags of a command in a newOptions
section likekubectl
. For example: