[1.14] gateway-api: update types to read v1beta1 if present (#41238) #41259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * gateway-api: update types to read v1beta1 if present The upstream API is dropping support for the v1alpha2 types for HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike Istio where we always read the alpha versions in Istiod, we must switch to reading the beta types or users on v0.6.0 (next release of API) will be broken. This means that the minimum version of the API is v0.5.0; most users are upgrading quickly since v0.4.0 was still an alpha API. (cherry picked from commit fc33f94) * fixes (cherry picked from commit dbf424b)
|
Skipping CI for Draft Pull Request. |
istio-testing
added
the
do-not-merge/work-in-progress
|
/test all |
istio-testing
added
the
size/XXL
|
/test all |
|
/test all |
1 similar comment
|
/test all |
|
/retest |
|
/test all |
|
/test all |
|
/tests all |
|
/test all |
lei-tang
reviewed
Oct 5, 2022
lei-tang
approved these changes
Oct 5, 2022
|
/retest |
istio-testing
removed
the
do-not-merge/work-in-progress
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Oct 6, 2022
) (istio#41259) * [1.14] gateway-api: update types to read v1beta1 if present (istio#41238) * gateway-api: update types to read v1beta1 if present The upstream API is dropping support for the v1alpha2 types for HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike Istio where we always read the alpha versions in Istiod, we must switch to reading the beta types or users on v0.6.0 (next release of API) will be broken. This means that the minimum version of the API is v0.5.0; most users are upgrading quickly since v0.4.0 was still an alpha API. (cherry picked from commit fc33f94) * fixes (cherry picked from commit dbf424b) * fixes * fixes * fix conformance * lint * remove entirely (cherry picked from commit 84a45e7)
istio-testing
pushed a commit
that referenced
this pull request
Oct 6, 2022
…41259) (#41289) * [1.14] gateway-api: update types to read v1beta1 if present (#41238) * gateway-api: update types to read v1beta1 if present The upstream API is dropping support for the v1alpha2 types for HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike Istio where we always read the alpha versions in Istiod, we must switch to reading the beta types or users on v0.6.0 (next release of API) will be broken. This means that the minimum version of the API is v0.5.0; most users are upgrading quickly since v0.4.0 was still an alpha API. (cherry picked from commit fc33f94) * fixes (cherry picked from commit dbf424b) * fixes * fixes * fix conformance * lint * remove entirely (cherry picked from commit 84a45e7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream API is dropping support for the v1alpha2 types for HTTPRoute, Gateway, and GatewayClass in the next release. So, unlike Istio where we always read the alpha versions in Istiod, we must switch to reading the beta types or users on v0.6.0 (next release of API) will be broken.
This means that the minimum version of the API is v0.5.0; most users are upgrading quickly since v0.4.0 was still an alpha API.
(cherry picked from commit fc33f94)
(cherry picked from commit dbf424b)
Please provide a description of this PR: