Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-arch releaseTar URL #41483

Merged
merged 8 commits into from
Nov 4, 2022
Merged

Add support for multi-arch releaseTar URL #41483

merged 8 commits into from
Nov 4, 2022

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Oct 18, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
The path shouldn't be fixed amd64 anymore.
The result on arm is like:

 -d, --manifests string             Specify a path to a directory of charts and profiles
                                     (e.g. ~/Downloads/istio-1.16.0/manifests)
                                     or release tar URL (e.g. https://github.com/istio/istio/releases/download/1.16.0/istio-1.16.0-linux-arm64.tar.gz).

Please check any characteristics that apply to this pull request.

  • [] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hanxiaop hanxiaop requested a review from a team as a code owner October 18, 2022 10:12
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2022
@hanxiaop hanxiaop requested a review from a team as a code owner October 18, 2022 10:15
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2022
ericvn
ericvn reviewed Oct 18, 2022
View reviewed changes
common/scripts/report_build_info.sh Outdated
@@ -44,3 +44,4 @@ echo "istio.io/pkg/version.buildGitRevision=${BUILD_GIT_REVISION}"
echo "istio.io/pkg/version.buildStatus=${tree_status}"
echo "istio.io/pkg/version.buildTag=${GIT_DESCRIBE_TAG}"
echo "istio.io/pkg/version.buildHub=${HUB}"
echo "istio.io/pkg/version.buildArch=${TARGET_ARCH}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files in the common directory come from istio/common-files. This change would need to be made in that repo and when committed, it will propagate to the other repos like here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericvn Thanks

@hanxiaop hanxiaop added the do-not-merge/hold Block automatic merging of a PR. label Oct 18, 2022
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 21, 2022
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 24, 2022
@hanxiaop hanxiaop requested a review from ericvn October 24, 2022 06:17
@hanxiaop hanxiaop removed the do-not-merge/hold Block automatic merging of a PR. label Oct 24, 2022
@hanxiaop
Copy link
Member Author

/test lint

zhlsunshine
zhlsunshine reviewed Oct 25, 2022
View reviewed changes
pkg/url/url.go Outdated Show resolved Hide resolved
@hanxiaop
Copy link
Member Author

hanxiaop commented Nov 4, 2022

@istio/wg-test-and-release-maintainers PTAL. Thanks

@istio-testing istio-testing merged commit c396e4d into istio:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhlsunshine zhlsunshine zhlsunshine left review comments

@ericvn ericvn ericvn approved these changes

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees
No one assigned
Labels
area/test and release area/user experience size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hanxiaop @zhlsunshine @ericvn @istio-testing @istio-policy-bot