-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote cluster sync timeout issue #42252
Fix remote cluster sync timeout issue #42252
Conversation
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
Can you elaborate on this |
The HasSync method only cares about the var istio/pilot/pkg/serviceregistry/kube/controller/controller.go Lines 837 to 854 in 8548a35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a release note, it need to be backported
f4c4e21
to
2450c85
Compare
2450c85
to
5aabdfd
Compare
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release Notes LGTM
/retest |
Currently, the informerInit marker doesn't work for remote cluster sync timeout case. Remove it and use the initialSync marker.
CC @hzxuzhonghu