istiod: fully drop xds v2 #44679
Merged
istiod: fully drop xds v2 #44679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes support for using v2 in Envoyfilters. Users previously got a warning. They will now get an error, which helpfully points them to using v3. This has been warning for well over 2 years at this point, so I think its time. This reduces the binary size of Pilot by 8mb which is a nice benefit as well. Note: the current support for v2 is mostly only for top level fields. This works because we marshal to Struct then back into the v3 types. For things like ADD, we don't do this and send as-is (v2), but Envoy itself only partially supports v2. For example, config_dump will break. So its unlikely there is usage.
istio-testing
added
the
size/S
jacob-delgado
approved these changes
May 2, 2023
ramaraochavali
approved these changes
May 2, 2023
|
/test integ-ipv6 |
|
/retest
…On Tue, May 2, 2023, 6:22 AM Istio Automation ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn>: The following test *failed*,
say /retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
unit-tests_istio 448bd86
<448bd86>
link
<https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/44679/unit-tests_istio/1653386500898820096>
unknown /test unit-tests
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub
<#44679 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXJDSFOYVLPOYNRV5EDXEEDBHANCNFSM6AAAAAAXSFZVXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for using v2 in Envoyfilters. Users previously got a warning. They will now get an error, which helpfully points them to using v3.
This has been warning for well over 2 years at this point, so I think its time. This reduces the binary size of Pilot by 8mb which is a nice benefit as well.
Note: the current support for v2 is mostly only for top level fields. This works because we marshal to Struct then back into the v3 types. For things like ADD, we don't do this and send as-is (v2), but Envoy itself only partially supports v2. For example, config_dump will break. So its unlikely there is usage.