Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istiod: fully drop xds v2 #44679

Merged
merged 1 commit into from
May 2, 2023
Merged

istiod: fully drop xds v2 #44679

merged 1 commit into from
May 2, 2023

Commits on May 1, 2023

  1. istiod: fully drop xds v2 

    This removes support for using v2 in Envoyfilters. Users previously got
a warning. They will now get an error, which helpfully points them to
using v3.

This has been warning for well over 2 years at this point, so I think
its time. This reduces the binary size of Pilot by 8mb which is a nice
benefit as well.

Note: the current support for v2 is mostly only for top level fields.
This works because we marshal to Struct then back into the v3 types. For
things like ADD, we don't do this and send as-is (v2), but Envoy itself only
partially supports v2. For example, config_dump will break. So its
unlikely there is usage.
    @howardjohn
    howardjohn committed May 1, 2023
    Configuration menu
    Copy the full SHA
    448bd86 View commit details
    Browse the repository at this point in the history