Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automator: update proxy@master in istio/istio@master #47532

Conversation

istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented Oct 23, 2023

Generated by Automator - 2023-10-31T15:27:58+00:00

@istio-testing istio-testing added the auto-merge Set this label on a PR to auto-merge it on success of presubmit tests label Oct 23, 2023
@istio-testing istio-testing added the release-notes-none Indicates a PR that does not require release notes. label Oct 23, 2023
@istio-testing istio-testing force-pushed the master-master-update_proxy_dep-a9934e34 branch from 32a6ac6 to fcfd953 Compare October 23, 2023 19:55
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@ericvn
Copy link
Contributor

ericvn commented Oct 23, 2023

/retest

1 similar comment
@zirain
Copy link
Member

zirain commented Oct 24, 2023

/retest

@istio-testing istio-testing force-pushed the master-master-update_proxy_dep-a9934e34 branch from fcfd953 to fa0fc72 Compare October 24, 2023 21:02
@zirain
Copy link
Member

zirain commented Oct 24, 2023

@kyessenov related to authn changes?

@ericvn
Copy link
Contributor

ericvn commented Oct 24, 2023

Failures in TestRequestAuthentication

@istio-testing istio-testing force-pushed the master-master-update_proxy_dep-a9934e34 branch 2 times, most recently from 581f542 to 700f093 Compare October 25, 2023 08:08
@zirain
Copy link
Member

zirain commented Oct 25, 2023

2023-10-25T09:08:26.002995Z     warn    ads     ADS:LDS: ACK ERROR httpbin-67f8fbcd48-r72j7.default-5 Internal:Error adding/updating listener(s) virtualInbound: Provider 'origins-0' in jwt_authn config has invalid local jwks: Jwks RSA [n] or [e] field is missing or has a parse error
{
              "name": "envoy.filters.http.jwt_authn",
              "typed_config": {
               "@type": "type.googleapis.com/envoy.extensions.filters.http.jwt_authn.v3.JwtAuthentication",
               "providers": {
                "origins-0": {
                 "issuer": "test-issuer-1@istio.io",
                 "local_jwks": {
                  "inline_string": "{\"keys\":[ {\"e\":\"AQAB\",\"kid\":\"abc\",\"kty\":\"RSA\",\"n\":\"RXJyb3ItSXN0aW9kRmFpbGVkVG9GZXRjaEp3a3NVcmktaHR0cHM6Ly9yYXcuZ2l0aHVidXNlcmNvbnRlbnQuY29tL2lzdGlvL2lzdGlvL21hc3Rlci90ZXN0cy9jb21tb24vand0L2p3a3Mtbm90LWV4aXN0Lmpzb24\"}]}"
                 },
                 "payload_in_metadata": "test-issuer-1@istio.io"
                }
               },
               "rules": [
                {
                 "match": {
                  "prefix": "/"
                 },
                 "requires": {
                  "requires_any": {
                   "requirements": [
                    {
                     "provider_name": "origins-0"
                    },
                    {
                     "allow_missing": {}
                    }
                   ]
                  }
                 }
                }
               ],
               "bypass_cors_preflight": true
              }
             },

@zirain
Copy link
Member

zirain commented Oct 25, 2023

seems related to envoyproxy/envoy#30001

@kyessenov
Copy link
Contributor

Yeah, there was a feature in Envoy that probably affected Istio.

@kyessenov
Copy link
Contributor

@aryan16 Are you familiar with how we generated the test JWKs? Why are they suddenly malformed?

@zirain
Copy link
Member

zirain commented Oct 25, 2023

@aryan16 Are you familiar with how we generated the test JWKs? Why are they suddenly malformed?

Verification has become more stringent.

@zirain zirain mentioned this pull request Oct 27, 2023
@istio-testing istio-testing force-pushed the master-master-update_proxy_dep-a9934e34 branch 2 times, most recently from 5ef6d6d to 6bd4341 Compare October 29, 2023 02:28
@zirain zirain reopened this Oct 31, 2023
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 31, 2023
@zirain
Copy link
Member

zirain commented Oct 31, 2023

/rebase

@zirain
Copy link
Member

zirain commented Oct 31, 2023

this should be OK tomorrow, let's what will happen.

@ericvn
Copy link
Contributor

ericvn commented Oct 31, 2023

This job will never see any updates until the envoy updates in the main branch are fixed. The pipeline job is broken. For example see https://prow.istio.io/view/gs/istio-prow/logs/update-proxy_proxy_periodic/1718687415981314048, and I talked about it here: https://istio.slack.com/archives/CNWHGSBHA/p1698515622875269.

@zirain
Copy link
Member

zirain commented Oct 31, 2023

I think this's the root cause:

git ls-remote https://github.com/envoyproxy/envoy main
a699868c39fc1da067e9a442e391f1cd2694f175	refs/heads/main
3127d5fa97c5b30ed6017ef291379a8cb9fdebb5	refs/heads/release/create/main
8ec3b846a95d1567d97aa24e386bc5ed2d0c2afe	refs/heads/release/sync/main

@zirain
Copy link
Member

zirain commented Oct 31, 2023

xhref: istio/proxy#5104

@istio-testing istio-testing force-pushed the master-master-update_proxy_dep-a9934e34 branch from 6bd4341 to 88ada6a Compare October 31, 2023 15:31
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 31, 2023
@istio-testing istio-testing merged commit 95de7ec into istio:master Oct 31, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants