Improve CreateFakeJwks #47621
Merged
Improve CreateFakeJwks #47621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
requested review from
a team,
costinm,
linsun,
howardjohn,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
istio-testing
added
do-not-merge/work-in-progress
zirain
added
the
release-notes-none
istio-testing
added
size/L
zirain
force-pushed
the
fake-jwks
branch
2 times, most recently
from
9103721
to
8c0e089
Compare
istio-testing
removed
the
do-not-merge/work-in-progress
howardjohn
reviewed
Oct 27, 2023
istio-testing
added
size/M
hzxuzhonghu
approved these changes
Oct 31, 2023
hzxuzhonghu
reviewed
Oct 31, 2023
| // Encode jwksURI with base64 to make dynamic n in jwks | ||
| encodedString := base64.RawURLEncoding.EncodeToString([]byte(fakeJwksURI)) | ||
| return fmt.Sprintf(`{"keys":[ {"e":"AQAB","kid":"abc","kty":"RSA","n":"%s"}]}`, encodedString) | ||
| func CreateFakeJwks() string { |
There was a problem hiding this comment.
Is this a const, can we cache it
There was a problem hiding this comment.
This is still not stable and will result in XDS draining as we hop between instances every 30min. This is really bad and this exact issue has caused massive production issues for our customers in the past./
This must be static and deterministic.
howardjohn
added a commit
that referenced
this pull request
Oct 31, 2023
This reverts commit 968a6f9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #47532
see details:
#47532 (comment)
#47532 (comment)