Revert "Improve CreateFakeJwks" #47661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 968a6f9.
howardjohn
added
the
release-notes-none
howardjohn
requested review from
a team,
costinm,
linsun,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
istio-testing
added
the
size/M
|
Yes, forward fix is necessary since this was blocking Envoy update. |
|
yes, there's a predictable issue after rollout of istiod pod. |
|
yeah single static key sgtm
…On Tue, Oct 31, 2023, 4:35 PM zirain ***@***.***> wrote:
yes, there's a predictable issue after rollout of istiod pod.
what about using a bulit-in key?
—
Reply to this email directly, view it on GitHub
<#47661 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXMDSR36JHZYH5HTHRTYCGDKVAVCNFSM6AAAAAA6X6YQWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGE3TMNBWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Merged
istio-testing
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #47621
See #47621 (comment)
Mostly opening this so I don't forget, probably easiest to forward-fix this instead of reverting @zirain