Fix misc RBAC issues on 1.6.6 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any way to get a test for this (failing without the fix and passing with it) ? Also can you describe a bit the fix/symptoms etc by editing the PR description (if we want to put this in the stable release-0.1 branch we need to be extra descriptive with the changes) |
|
Jenkins job istio/presubmit passed |
costinm
approved these changes
Jul 18, 2017
|
Create a cluster in GKE with 1.6.6 version and deploy istio, then do kubectl logs pilot-... , kubectl logs ingress-.... |
lachie83
added a commit
to lachie83/istio
that referenced
this pull request
Jul 19, 2017
…lachie83/istio into bugfix-resync-alpha-beta-rbac-manifests * 'bugfix-resync-alpha-beta-rbac-manifests' of github.com:lachie83/istio: Fix misc RBAC issues on 1.6.6 (istio#477)
guptasu
pushed a commit
to guptasu/istio
that referenced
this pull request
Jun 11, 2018
Also, fix python generation logic to stop passing directory names as proto files. This eliminates a bunch of warnings when building the repo, and eliminates a bunch of broken dud checked in files.
kyessenov
pushed a commit
to kyessenov/istio
that referenced
this pull request
Aug 13, 2018
* update envoy sha adding regex match support in routes * no more filter types * more nixing * interactive compilation with Jenkins * hopefully the last compilation fix * one more * one more * another one
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
And remove values_gke.yaml Closes istio#18576
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
* WIP: Refine e2e implementation This is a refinement based upon the prior PRs in this area. Depends-On: istio/tools#483 * Use proper image with jq
luksa
added a commit
to luksa/istio
that referenced
this pull request
Sep 20, 2022
antonioberben
pushed a commit
to antonioberben/istio
that referenced
this pull request
Jan 29, 2024
[jaeger] Add option to configure ingester only via environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded to a k8s 1.6.6 cluster and pilot can no longer read TPRs.
I0718 23:23:06.618825 1 client.go:194] TPR "IstioConfig" is not ready (User "system:serviceaccount:istio-test-nb5kb:istio-pilot-service-account" cannot list istioconfigs.istio.io at the cluster scope.: "Unknown user "system:serviceaccount:istio-test-nb5kb:istio-pilot-service-account"" (get IstioConfigs.istio.io)). Waiting...
Fixed also Ingress status, who was no longer updated after adding the k8s Syncer, because we were missing list permissions on the nodes.
This version is now in sync with the e2e tests in pilot, that can be run independently on an RBAC enabled cluster.