Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automator: update ztunnel@master in istio/istio@master #49609

Conversation

istio-testing
Copy link
Collaborator

@istio-testing istio-testing commented Feb 28, 2024

Generated by Automator - 2024-03-17T15:36:32+00:00

@istio-testing istio-testing added auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. labels Feb 28, 2024
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2024
@ericvn
Copy link
Contributor

ericvn commented Feb 28, 2024

/test integ-ambient

@ericvn
Copy link
Contributor

ericvn commented Feb 28, 2024

Issue with istio/ztunnel#820?

@hzxuzhonghu
Copy link
Member

seems not

@hzxuzhonghu
Copy link
Member

/retest

@hzxuzhonghu
Copy link
Member

istio/ztunnel#768 is the only pr related to cert

@hanxiaop
Copy link
Member

cc @MorrisLaw

@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch from 46415b8 to b893636 Compare February 29, 2024 15:33
@MorrisLaw
Copy link
Contributor

MorrisLaw commented Feb 29, 2024

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-ambient_istio b893636 link true /test integ-ambient

Looking into this. I think the issue is with the more dynamic retry time for refreshing certs. Used to be 60 seconds, the retry duration now starts at 500ms and gets up to as high as 2.5 minutes. The integration test may need to be updated to account for this, if it doesn't already.

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2024
@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch 2 times, most recently from 6ba7257 to e67f54c Compare March 2, 2024 15:33
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 2, 2024
@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch 2 times, most recently from c62852d to eb5eaed Compare March 4, 2024 15:33
@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch 2 times, most recently from d6a0d9f to 0ac14d1 Compare March 6, 2024 15:34
@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch 7 times, most recently from 3c2396c to 3c5236c Compare March 13, 2024 15:35
@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch 3 times, most recently from 6445ed2 to dbfa73b Compare March 16, 2024 15:36
@istio-testing istio-testing force-pushed the none-master-update_ztunnel_dep-02a794b5 branch from dbfa73b to 0bd5347 Compare March 17, 2024 15:36
@istio-testing
Copy link
Collaborator Author

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-ambient_istio 0bd5347 link true /test integ-ambient

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw MorrisLaw closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Set this label on a PR to auto-merge it on success of presubmit tests release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants