Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry backoff to cert refresh #768

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Add retry backoff to cert refresh #768

merged 8 commits into from
Feb 21, 2024

Conversation

MorrisLaw
Copy link
Contributor

@MorrisLaw MorrisLaw commented Jan 11, 2024 •
edited
Loading

Add backoff retry logic as the mechanism for determining the refresh_at value for fetching certificates.

Related to issue #725.

@MorrisLaw MorrisLaw requested a review from a team as a code owner January 11, 2024 18:22
@istio-policy-bot
Copy link

😊 Welcome @MorrisLaw! This is either your first contribution to the Istio ztunnel repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2024
@MorrisLaw MorrisLaw marked this pull request as draft January 11, 2024 18:24
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 11, 2024
@MorrisLaw MorrisLaw force-pushed the add-retry-backoff-to-cert-refresh branch from 2d794da to f81465c Compare January 11, 2024 18:25
howardjohn
howardjohn reviewed Jan 12, 2024
View reviewed changes
src/identity/manager.rs Outdated Show resolved Hide resolved
src/identity/manager.rs Outdated Show resolved Hide resolved
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 20, 2024
@MorrisLaw MorrisLaw force-pushed the add-retry-backoff-to-cert-refresh branch from 02bd909 to 1042f33 Compare February 5, 2024 19:04
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2024
@MorrisLaw MorrisLaw force-pushed the add-retry-backoff-to-cert-refresh branch from dba189f to 7edf72e Compare February 8, 2024 21:32
@MorrisLaw MorrisLaw removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 8, 2024
@MorrisLaw MorrisLaw marked this pull request as ready for review February 8, 2024 21:33
@MorrisLaw MorrisLaw mentioned this pull request Feb 8, 2024
Closed
@MorrisLaw MorrisLaw force-pushed the add-retry-backoff-to-cert-refresh branch from 3801eac to 818c8ef Compare February 9, 2024 04:25
keithmattix
keithmattix reviewed Feb 9, 2024
View reviewed changes
src/identity/manager.rs Outdated Show resolved Hide resolved
howardjohn
howardjohn reviewed Feb 12, 2024
View reviewed changes
src/identity/manager.rs Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2024
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2024
@MorrisLaw
Copy link
Contributor Author

/retest-required

keithmattix
keithmattix approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but of course other ztunnel experts need to approve as well

@istio-testing istio-testing merged commit 44a1629 into istio:master Feb 21, 2024
3 checks passed
@MorrisLaw MorrisLaw deleted the add-retry-backoff-to-cert-refresh branch February 21, 2024 23:21
@hzxuzhonghu hzxuzhonghu mentioned this pull request Feb 29, 2024
Closed
MorrisLaw added a commit to MorrisLaw/ztunnel that referenced this pull request Mar 1, 2024
@MorrisLaw
Revert Add retry backoff to cert refresh (istio#768)
00b1602
@MorrisLaw MorrisLaw mentioned this pull request Mar 1, 2024
Merged
istio-testing pushed a commit that referenced this pull request Mar 4, 2024
@MorrisLaw
Revert Add retry backoff to cert refresh (#768) (#833)
6719e48
@MorrisLaw MorrisLaw restored the add-retry-backoff-to-cert-refresh branch March 4, 2024 19:20
stevenctl pushed a commit to stevenctl/ztunnel that referenced this pull request Mar 11, 2024
@MorrisLaw @stevenctl
Revert Add retry backoff to cert refresh (istio#768) (istio#833)
95ece7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@keithmattix keithmattix keithmattix approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MorrisLaw @istio-policy-bot @howardjohn @keithmattix @istio-testing