Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP/Do Not Merge: a PR to fail presubmit #503

Closed
wants to merge 4 commits into from
Closed

WIP/Do Not Merge: a PR to fail presubmit #503

wants to merge 4 commits into from

Conversation

chxchx
Copy link
Contributor

@chxchx chxchx commented Jul 27, 2017

No description provided.

@istio-testing
Copy link
Collaborator

@chxchx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-presubmit.sh 80bdd9b link @istio-testing bazel test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chxchx
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@chxchx chxchx closed this Aug 1, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
@geeknoid
Update some shas and use gogo options. (istio#503)
72672ac 
* Update some shas.

- Get latest gogo build rules so we can finally get the latest gogo bits
with a bug fix I've been waiting for.

- Get latest grpc release which solves some spurious output I see on
shutdown during tests.

* Update our config protos to leverage gogo codegen options.


Former-commit-id: af2e1b3be54cdf3d32d4b5e7849ea01a8a9ae43d
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@geeknoid
Update some shas and use gogo options. (#503)
0058a86 
* Update some shas.

- Get latest gogo build rules so we can finally get the latest gogo bits
with a bug fix I've been waiting for.

- Get latest grpc release which solves some spurious output I see on
shutdown during tests.

* Update our config protos to leverage gogo codegen options.


Former-commit-id: 759a214ab7ec52b88cf9016078028b4793580a95
guptasu pushed a commit to guptasu/istio that referenced this pull request Jun 11, 2018
@hklai
Merge pull request istio#503 from hklai/release-0.8
19931a4 
Merging release-0.8 to master
kyessenov pushed a commit to kyessenov/istio that referenced this pull request Aug 13, 2018
@qiwzhang
Support ipv6 in converting Pilot mesh ip attributes. (istio#503)
d94e954
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@jmazzitelli @istio-testing
[kiali] update to Kiali v1.9 (istio#503)
ff20874
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@ericvn @istio-testing
fix make update-golden when run from a Mac (istio#503)
c3a213d
luksa pushed a commit to luksa/istio that referenced this pull request Apr 29, 2022
@maistra-bot
Automator: Update proxy (istio#503)
9f856a5 
Co-authored-by: maistra-bot <null>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chxchx @istio-testing @istio-merge-robot @googlebot