Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to include pre-processing Mixer PR #683

Closed
wants to merge 1 commit into from
Closed

Update to include pre-processing Mixer PR #683

wants to merge 1 commit into from

Conversation

mandarjog
Copy link
Contributor

This build of mixer preprocesses attributes correctly.
Release note:

NONE

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: geeknoid

Assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

ZackButcher
ZackButcher reviewed Sep 6, 2017
View reviewed changes
Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sunny also has a PR going in updating Mixer SHA. Which needs to go in first, and why isn't the normal process keeping these up to date working?

@mandarjog
Copy link
Contributor Author

mandarjog commented Sep 6, 2017 •
edited
Loading

@ZackButcher there is no nomal process. A person does it :-)

@istio-merge-robot
Copy link

@mandarjog PR needs rebase

@istio-merge-robot istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Sep 6, 2017
@istio-testing
Copy link
Collaborator

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh 95db018 link /test e2e-suite-rbac-auth
prow/e2e-suite-rbac-no_auth.sh 95db018 link /test e2e-suite-rbac-no_auth
prow/e2e-suite-no_rbac-no_auth.sh 95db018 link /test e2e-suite-no_rbac-no_auth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram rshriram changed the title Update to includes proprocessing Mixer PR Update to include pre-processing Mixer PR Sep 6, 2017
@ldemailly
Copy link
Member

rebase and/or abandon in favor of https://github.com/istio/istio/pull/692/files or the next auto update PR ?

@rshriram rshriram closed this Sep 7, 2017
mandarjog pushed a commit to mandarjog/istio that referenced this pull request Oct 30, 2017
@ldemailly @geeknoid
Warn about missing binary/bazel build instead of dirname errors (isti…
94e863c 
…o#683)

Fixes issue istio#676

Former-commit-id: 2811be651a8fe099cf9d94b90bb5116399a0722e
@mandarjog mandarjog deleted the mixer_preprocess branch October 30, 2017 21:07
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@ldemailly @geeknoid
Warn about missing binary/bazel build instead of dirname errors (#683)
89452f5 
Fixes issue #676

Former-commit-id: 5bae502af7492b59d0a59d7f2e89bd95d1088efe
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
@elfinhe @istio-testing
Simplify outputs, hide component detail results if no errors. (istio#683
63a8861 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackButcher ZackButcher ZackButcher left review comments

@douglas-reid douglas-reid Awaiting requested review from douglas-reid

Assignees
No one assigned
Labels
needs-rebase Indicates a PR needs to be rebased before being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mandarjog @istio-merge-robot @istio-testing @ldemailly @ZackButcher @googlebot @rshriram