Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Generate envoy virtual host entry for pod IP and port #150

Closed
rshriram opened this issue Feb 15, 2017 · 5 comments
Closed

Generate envoy virtual host entry for pod IP and port #150

rshriram opened this issue Feb 15, 2017 · 5 comments
Assignees
Labels

Comments

@rshriram
Copy link
Member

Ingress controllers like Nginx use the pod IP instead of service IP. In such a case, Envoy drops the incoming request as the host headers no longer match. Currently the proxy config generator creates virtual hosts only for all variations of service name and the service cluster IP. It needs to take the local pod IP into account as well.
cc @kyessenov

@rshriram rshriram added the bug label Feb 15, 2017
@kyessenov
Copy link
Contributor

Is it important to support pod IPs directly? There's a lot more churn in the pod registry, to the point we add this now, Envoy will be constantly restarting.

@kyessenov
Copy link
Contributor

Or is this just for inbound connection?

@kyessenov kyessenov self-assigned this Feb 15, 2017
@rshriram
Copy link
Member Author

Its inbound.. from an ingress controller. Just to be able to match the pod's local IP, when its present in the host field.
I don't think we need to restart at all.

@zcahana
Copy link
Member

zcahana commented Feb 16, 2017

I'm hitting this as well when testing the envoy-based ingress controller in #71.

I'm assigning this to myself as I plan to work on it on Sunday (yes it's a working day in here...).
If anyone else wanna give it a go before, that's fine too.

@zcahana
Copy link
Member

zcahana commented Feb 16, 2017

Oh, I didn't notice this is already assigned to @kyessenov. So, if you don't get the time to work it and want me to roll it next week, let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants