Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubetest2 version to include the change in https://github.com/kubernetes-sigs/kubetest2/pull/93 #1453

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Update kubetest2 version to include the change in https://github.com/kubernetes-sigs/kubetest2/pull/93 #1453

merged 1 commit into from
Feb 23, 2021

Conversation

chizhg
Copy link
Contributor

@chizhg chizhg commented Feb 23, 2021

Update kubetest2 version to include the change in kubernetes-sigs/kubetest2#93

@chizhg chizhg requested a review from a team as a code owner February 23, 2021 19:59
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 23, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2021
ericvn
ericvn approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to run make gen and pick up the additional file changes.

@ericvn
Copy link
Contributor

ericvn commented Feb 23, 2021 •
edited
Loading

Interestingly, I'm running into an issue with trying that myself...

make format-go
ERRO Running error: context loading failed: no go files to analyze
common/Makefile.common.mk:81: recipe for target 'format-go' failed

if I run the command that the make is running I did get get changes:

git status
On branch gofumpt
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   cmd/envvarlinter/rules/no_os_env.go
	modified:   cmd/envvarlinter/rules_matcher.go
	modified:   cmd/testlinter/rules_matcher.go
	modified:   perf/benchmark/security/generate_policies/generate.go

@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2021
@istio-testing istio-testing merged commit d1920f5 into istio:master Feb 23, 2021
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
@chizhg
Update kubetest2 version to include the change in kubernetes-sigs/kub…
3ecf234 
…etest2#93 (istio#1453)
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jul 6, 2022
@chizhg
Update kubetest2 version to include the change in kubernetes-sigs/kub…
50a5414 
…etest2#93 (istio#1453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@ericvn ericvn ericvn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chizhg @ericvn @howardjohn @istio-testing