-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graceful shutdown test #48
Conversation
This test sends long lasting requests to a server that is restarted repeatedly. This is used to test that traffic will be dropped gracefully rather than connections dropped.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
app: httpbin | ||
spec: | ||
containers: | ||
- image: docker.io/kennethreitz/httpbin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use fortio here if it supports those options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was initially using fortio, but the delay for fortio is maxed out at 1.5s. httpbin also has a limit, but it is 10s. Having a longer delay may expose more issues, but 1.5s is also pretty long, so we could switch to that if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok httpbin fine then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I assume some automated tests will follow?
Make sure you're identifying errors from severed connections and not unresponsive endpoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@mandarjog: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
consider a PR to make the max delay for fortio configurable (fortio/fortio#272) |
fixed in fortio/fortio#414 in fortio 1.9.1 |
This test sends long lasting requests to a server that is restarted repeatedly. This is used to test that traffic will be dropped gracefully rather than connections dropped.
This test sends long lasting requests to a server that is restarted
repeatedly. This is used to test that traffic will be dropped gracefully
rather than connections dropped.
@liamawhite