Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graceful shutdown test #48

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Conversation

howardjohn
Copy link
Member

This test sends long lasting requests to a server that is restarted
repeatedly. This is used to test that traffic will be dropped gracefully
rather than connections dropped.

@liamawhite

This test sends long lasting requests to a server that is restarted
repeatedly. This is used to test that traffic will be dropped gracefully
rather than connections dropped.
@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

app: httpbin
spec:
containers:
- image: docker.io/kennethreitz/httpbin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fortio here if it supports those options.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially using fortio, but the delay for fortio is maxed out at 1.5s. httpbin also has a limit, but it is 10s. Having a longer delay may expose more issues, but 1.5s is also pretty long, so we could switch to that if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok httpbin fine then.

Copy link
Member

@liamawhite liamawhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume some automated tests will follow?

Make sure you're identifying errors from severed connections and not unresponsive endpoints.

Copy link
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Contributor

@mandarjog: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandarjog mandarjog merged commit 3eac069 into istio:master Feb 11, 2019
@howardjohn howardjohn deleted the graceful-shutdown branch February 11, 2019 18:16
@ldemailly
Copy link
Contributor

consider a PR to make the max delay for fortio configurable (fortio/fortio#272)

@ldemailly
Copy link
Contributor

consider a PR to make the max delay for fortio configurable (fortio/fortio#272)

fixed in fortio/fortio#414 in fortio 1.9.1
(which also has tee off mode and a bunch of shiny new features, see
https://github.com/fortio/fortio/releases )

Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
This test sends long lasting requests to a server that is restarted
repeatedly. This is used to test that traffic will be dropped gracefully
rather than connections dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants