dns: fix search lookup #1099
Merged
dns: fix search lookup #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
release-notes-none
istio-testing
added
the
size/L
ilrudie
reviewed
Jun 3, 2024
bleggett
reviewed
Jun 3, 2024
istio-testing
added
the
needs-rebase
Fixes istio#1074 (issue was incorrect basically). Before our search domain was always ztunnel's (istio-system). This is incorrect; we should know the search domain of the request. We don't know the per-pod custom settings (istio#555), but we can use the correct defaults.
istio-testing
removed
the
needs-rebase
ilrudie
approved these changes
Jun 4, 2024
|
In response to a cherrypick label: #1099 failed to apply on top of branch "release-1.22": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #1112 |
howardjohn
added a commit
to howardjohn/ztunnel
that referenced
this pull request
Jun 6, 2024
* dns: fix search lookup Fixes istio#1074 (issue was incorrect basically). Before our search domain was always ztunnel's (istio-system). This is incorrect; we should know the search domain of the request. We don't know the per-pod custom settings (istio#555), but we can use the correct defaults. * Fix unwrap (cherry picked from commit 2e41538)
istio-testing
pushed a commit
that referenced
this pull request
Jun 6, 2024
* dns: fix search lookup Fixes #1074 (issue was incorrect basically). Before our search domain was always ztunnel's (istio-system). This is incorrect; we should know the search domain of the request. We don't know the per-pod custom settings (#555), but we can use the correct defaults. * Fix unwrap (cherry picked from commit 2e41538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074 (issue was incorrect
basically).
Before our search domain was always ztunnel's (istio-system). This is incorrect; we
should know the search domain of the request.
We don't know the per-pod custom settings
(#555), but we can use the
correct defaults.