Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of logs for terminated connections #1187

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

howardjohn
Copy link
Member

Fixes #1155

This ensures when we drain a process we emit metrics

Fixes istio#1155

This ensures when we drain a process we emit metrics
@howardjohn howardjohn requested a review from a team as a code owner June 27, 2024 21:48
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Jun 27, 2024
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2024
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@istio-testing istio-testing merged commit 3114f81 into istio:master Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit end-of-process access logs
3 participants