Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadbeef-archreader compile failure fix+other issues #171

Open
pensive-fuzz opened this issue Aug 11, 2021 · 2 comments
Open

deadbeef-archreader compile failure fix+other issues #171

pensive-fuzz opened this issue Aug 11, 2021 · 2 comments

Comments

@pensive-fuzz
Copy link

Various concerns:

  • It has a compile failure:
    error: invalid conversion from ‘int’ to ‘blargg_err_t’ {aka ‘const char*’} [-fpermissive]
    This issue can be resolved with the blargg patch from the abandoned deadbeef-overlay. The other patch isn't needed to compile and I'm not sure of what value it does or doesn't bring.
  • Why is it named deadbeef-archreader over deadbeef-archive-reader? archreader is less descriptive, it's never referenced as such on its site, and you use the full name for other plugins in this repository
  • The description misspells DeaDBeeF and is otherwise awkwardly worded. I'd go with something like: DeaDBeeF archive reader plugin that enables playing files directly from RAR, 7z and Gzip archive files
  • You have the wrong license. It's licensed under LGPL-2.1
@istitov
Copy link
Owner

istitov commented Nov 10, 2021

Thanks for pointing it out will look into it ASAP!

@LebedevV
Copy link
Contributor

Many thanks, we applied corrections. Could you please check it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants