Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The backend implementation should remeber the pattern passed via Gaimon.patternFromData #13

Open
liplum opened this issue May 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@liplum
Copy link

liplum commented May 26, 2024

Since the pattern might be frequently played, for example, in a game, I'm concerned about the performance impact of always transfering and transforming a large json string.

@istornz istornz added the enhancement New feature or request label Jun 4, 2024
@istornz
Copy link
Owner

istornz commented Jun 4, 2024

Thanks for raising an issue, for now it's not supported but must be a great addition to the plugin!

@liplum liplum changed the title Does the backend implementation remeber the pattern passed via Gaimon.patternFromData? The backend implementation should remeber the pattern passed via Gaimon.patternFromData Jun 5, 2024
@liplum
Copy link
Author

liplum commented Jun 5, 2024

IMHO, giving every passed pattern an ID would do the trick.
for example:

await Gaimon.cachePattern(id, json);
await Gaimon.patternById(id);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants