Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: inviteToken should be generated as urlsafe #267

Merged
merged 1 commit into from
Oct 3, 2020
Merged

nodejs: inviteToken should be generated as urlsafe #267

merged 1 commit into from
Oct 3, 2020

Conversation

onk
Copy link
Contributor

@onk onk commented Oct 3, 2020

in ruby:

invite_token = SecureRandom.urlsafe_base64(64)

in golang:

inviteToken := base64.URLEncoding.EncodeToString(randomBytes)

in rust:

let invite_token = data_encoding::BASE64URL.encode(&random_bytes);

@onk
nodejs: inviteToken should be generated as urlsafe
4c198c6 
in ruby:

```ruby
invite_token = SecureRandom.urlsafe_base64(64)
```

in golang:

```golang
inviteToken := base64.URLEncoding.EncodeToString(randomBytes)
```

in rust:

```rust
let invite_token = data_encoding::BASE64URL.encode(&random_bytes);
```
@yosuke-furukawa
Copy link
Contributor

Good catch. Thank you.

@yosuke-furukawa yosuke-furukawa merged commit 929e06a into isucon:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onk @yosuke-furukawa