Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp issues #263

Closed
michalk-k opened this issue Apr 15, 2023 · 2 comments
Closed

timestamp issues #263

michalk-k opened this issue Apr 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@michalk-k
Copy link

I would like to report a few timestamp issues. I could report it separately but those share common problems. Changes I suggest will make reported values compliant with current HA standards.

  1. sensor.fordpass_lastrefresh

    • should be set to: device_class: timestamp
    • the value passed to this sensor should be ISO formatted (add T literal between date and time, for example: 2023-04-15 13:04:33+02:00)
  2. wrong format of timestamp attributes
    timestamp attributes found in entities are in the wrong format. It's American format with the date formatted as month-day-year.
    To allow further processing the expected format is year-month-day.
    Please note, using the American format may lead to interpretation errors in other countries, for example, what date is 03-04-2023? is it 3rd April or 4th Match?
    See the image below, the time of the last refresh is obviously correct (otherwise, but the timestamp attribute for ignition status has exchanged day and month values.
    Also, I suggest making all timestamps ISO compliant (with T literal between date and time)
    I believe the value itself represents GMT time. So the time from the image should look like 2023-04-15T11:04:44+00:00 (unless HA itself converts it to the local time zone which I don't believe it does)
    image

  3. weird data for fordpass_dieselSystemStatus

    • I'm sure it's not the proper format for json. Then what it should be?
    • timestamp issue, the same as described in point 2.
      image
@michalk-k michalk-k changed the title timestamps issues found in attributes are in wrong format timestamp issues Apr 15, 2023
@itchannel
Copy link
Owner

  1. I will add the device_class to that sensor in the next version, but the actual formatting is already T literal and then converted to local time using your local HA instance time.
  2. All attributes are just raw sensor values from the Fordpass API I don't do any processing on dates as this is just extra data the user can use in templates if they so wish.
  3. Agreed that shouldn't return that for the diesel sensor will have a look at that in the next version thanks.

@itchannel itchannel added the bug Something isn't working label Apr 18, 2023
@itchannel itchannel self-assigned this Apr 18, 2023
@itchannel
Copy link
Owner

Closing old issue for housekeeping

Please reopen if the issue is still present :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants