fix to pass EDITOR command with args

[tgfjt]

Hi 😸 I like mmv! Thank you for your creativity.

1. I wanted to set $EDITOR = vscode
2. but needed to wait the vscode instance finished
3. and then I set $EDITOR with args. this below:

export EDITOR="code --wait" # same error occurs w/ "vi -e" 

mmv *.svg
mmv: abort renames: exec: "code --wait": executable file not found in $PATH

I fixed to pass $EDITOR with args to exec.Command.
What do you think of the approach?

Thanks!

[itchyny]

It look cool, but how is it common or standard to do this? Apparently zsh does not support this (this is about variable expansion) and crontab on macOS does not.

 % export EDITOR="vi -e"
 % crontab -e
crontab: vi -e: No such file or directory

Maybe it's not supported in other applications too.

[tgfjt]

Exactly. I'm not sure that.
I only saw it git commit is wating for $EDITOR code --wait.
https://github.com/git/git/blob/master/editor.c#L63-L77

I try to look at other things.:)

[tgfjt]

I made sure of edit command in mysql-shell is also waiting code --wait.
(edit is new for me, never used this command before... )
https://github.com/mysql/mysql-shell/blob/master/src/mysqlsh/commands/command_edit.cc#L99

[itchyny]

Please change this split to strings.Fields.

[tgfjt]

👍 fixed fce8377

[tgfjt]

I didn't knew strings.Fields. Thanks!

[itchyny]

LGTM

[itchyny]

Released as v0.1.2.