Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle(universalLink) does not behave as described. #592

Closed
scottasoutherland opened this issue Feb 22, 2023 · 2 comments · Fixed by #795 or #800
Closed

handle(universalLink) does not behave as described. #592

scottasoutherland opened this issue Feb 22, 2023 · 2 comments · Fixed by #795 or #800

Comments

@scottasoutherland
Copy link
Contributor

scottasoutherland commented Feb 22, 2023

We upgrade from version 6.3.4 to version 6.4.9 of the Iterable SDK, and we ran into an issue where our deeplink routes are being routed twice.

It was discovered that the reason for this is the call to "handle(universalLink url: URL)" is now returning false where it used to return true for the same deeplink.

Upon closer examination, the reason seems to be that as per the documentation on this function, it says Returns: true if it is an Iterable link, or the value returned from IterableURLDelegate otherwise. However, the call makes it through to the URL Delegate, which returns true. But the call to handle(universalLink url: URL) returns false. This seems to be because the call inside DeepLinkManager-> handleUniversalLink went from this:

Screenshot 2023-02-22 at 11 21 41 AM

to this

Screenshot 2023-02-22 at 11 22 10 AM

As you can see it is no longer capturing the result from ActionRunner.execute and always returns false no matter what the URLDelegate returns.

@jonasman
Copy link

Any update here? this is a problem here also

@Ayyanchira

scottasoutherland added a commit to scottasoutherland/swift-sdk that referenced this issue Aug 1, 2024
scottasoutherland added a commit to scottasoutherland/swift-sdk that referenced this issue Aug 1, 2024
@scottasoutherland
Copy link
Contributor Author

Here is a pull request for this issue: #795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants