Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose close methods #44

Open
casperdcl opened this issue Jun 6, 2020 · 0 comments
Open

expose close methods #44

casperdcl opened this issue Jun 6, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Jun 6, 2020 •
edited
Loading

There should be a close method exposed (for example for MediaIoReadable) to close the underlying connection.

The underlying httplib2 library (https://github.com/httplib2/httplib2/blob/master/python3/httplib2/__init__.py) seems to auto-close() on Exception or on HEAD requests but not otherwise (i.e. not on deletion).
@casperdcl casperdcl added the enhancement New feature or request label Jun 6, 2020
@casperdcl casperdcl self-assigned this Jun 6, 2020
@casperdcl casperdcl changed the title close expose close methods Jun 6, 2020
@casperdcl casperdcl mentioned this issue Jun 6, 2020
Merged
8 tasks
@casperdcl casperdcl removed their assignment Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@casperdcl