Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all sklearn -> scikit-learn #330

Open
casperdcl opened this issue Sep 26, 2022 · 3 comments
Open

replace all sklearn -> scikit-learn #330

casperdcl opened this issue Sep 26, 2022 · 3 comments
Assignees
Labels
bug Something isn't working documentation Markdown files p1-important High priority

Comments

@casperdcl
Copy link
Contributor

Quite a few instances in https://github.com/search?l=Text&q=org%3Aiterative+sklearn&type=Code

See e.g. iterative/example_cml#256, iterative/cml_dvc_case#23

@casperdcl casperdcl added documentation Markdown files p1-important High priority bug Something isn't working labels Sep 26, 2022
@tasdomas
Copy link
Contributor

Is there really a supply chain issue here? sklearn is a dummy package that specifies scikit-learn as its only dependency. Sure, it's just a workaround for the import and package name mismatch in scikit-learn, but apart from the additional sklearn==0.0 line in the output of pip freeze there's no significant issue.

@dacbd
Copy link
Contributor

dacbd commented Sep 27, 2022

shot in the dark, but there have been a few issues of users asking for support on discord that has stemmed from pip install issues and sk[scikit-]learn versions, so if this is related to that 👍

@casperdcl
Copy link
Contributor Author

yes, we should fix it since it looks like the dummy package doesn't always install properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Markdown files p1-important High priority
Projects
None yet
Development

No branches or pull requests

3 participants